Skip to content

gh-151669: Normalize symlink targets in tarfile.TarFile.gettarinfo()#151671

Open
dnicolodi wants to merge 2 commits into
python:mainfrom
dnicolodi:fix/win-tarfile-gettarinfo
Open

gh-151669: Normalize symlink targets in tarfile.TarFile.gettarinfo()#151671
dnicolodi wants to merge 2 commits into
python:mainfrom
dnicolodi:fix/win-tarfile-gettarinfo

Conversation

@dnicolodi

@dnicolodi dnicolodi commented Jun 18, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

This applies a normalization complementary to the one added to tarfile.TarFile.extract() in gh-138309.

@dnicolodi
pythongh-151669: Normalize symlink targets in tarfile.TarFile.gettari…
b05605c 
…nfo()

This applies a normalization complementary to the one added to
tarfile.TarFile.extract() in pythongh-138309.
@dnicolodi dnicolodi requested a review from ethanfurman as a code owner June 18, 2026 19:58
@python-cla-bot

python-cla-bot Bot commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app Bot mentioned this pull request Jun 18, 2026
Open
@dnicolodi

dnicolodi commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

I think this change should be mentioned in NEWS next to the one to extract(). However, I don't know how amending exiting entries in NEWS is handled.

@dnicolodi dnicolodi mentioned this pull request Jun 19, 2026
Open
@bonzini

bonzini commented Jun 19, 2026

Copy link
Copy Markdown

According to the CI message, the news entry should be added to Misc/NEWS.d/next

@dnicolodi

dnicolodi commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

According to the CI message, the news entry should be added to Misc/NEWS.d/next

I understand this, but in this case I think the best would be to extend the NEWS entry added by gh-138309, and I don't know what is the policy for doing this.

@ngoldbaum

ngoldbaum commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Ping @encukou - @mgorny tells me this PR is needed by meson to add Python 3.15 and abi3t support.

@rgommers rgommers mentioned this pull request Jun 24, 2026
Merged
@ngoldbaum

ngoldbaum commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@hugovk can you help clarify how the news entry should be handled here? Should @dnicolodi simply add a new one?

@hugovk

hugovk commented Jun 24, 2026

Copy link
Copy Markdown
Member

The changelog is a never-ending history of archeological layers.

The NEWS entry added by #138309 is what happened in 3.15.0a1. That's the past.

The NEWS entry for this PR is what will happen in 3.15.0b4. Please add a new NEWS entry for this change.

General info: https://devguide.python.org/getting-started/pull-request-lifecycle/#updating-news-and-what-s-new-in-python

@dnicolodi dnicolodi requested a review from AA-Turner as a code owner June 24, 2026 21:35
@read-the-docs-community

read-the-docs-community Bot commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33297928 | 📁 Comparing 52b2be0 against main (1d55b37)

  🔍 Preview build  

2 files changed
± whatsnew/3.15.html
± whatsnew/changelog.html

@dnicolodi dnicolodi force-pushed the fix/win-tarfile-gettarinfo branch from 630da42 to 52b2be0 Compare June 24, 2026 21:51
@rgommers rgommers mentioned this pull request Jun 27, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dnicolodi @bonzini @ngoldbaum @hugovk